rewrite file matching for fs Open, ReadDir and Stat #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeidiDeng
force-pushed
the
fs-implicit-tweak
branch
2 times, most recently
from
ed7c8b2
to
7bf5364
Compare
WeidiDeng
force-pushed
the
fs-implicit-tweak
branch
from
7bf5364
to
3a4eded
Compare
I do use these in a project though. I will review this soon! Kind of taking the weekend off :) Thanks |
|
@WeidiDeng Is there any specific reason the Top* utility functions were removed? I'd be willing to consider this PR if we can keep those. |
I have no reason against these functions, just because new code paths don't use them. I can add back if you want to. |
|
@WeidiDeng Yeah, if we could add them back, I would appreciate it, since I use them in one of my projects :) |
mholt
approved these changes
Nov 30, 2022
mholt
added a commit
that referenced
this pull request
Aug 21, 2024
I think this is what @WeidiDeng intended from #354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite majority logic of fs Open, ReadDir and Stat
also fixes 340
ArchiveFS previously assume directory entries are always present in archive file listing when they are not. Also files under the same directory are stored together (add a test zip file that's a result of appending additional files to it).
Removed Top* utility func used to stat implicit directories.